multi: No string pointer on submit work. #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the SubmitWork function to take the submission directly instead of a pointer to it. Strings are already reference types, so there is no reason to take a pointer to a string unless the calee intended to change what the caller's string points at. Moreover, taking a pointer could also lead to unnecessary allocations.
davecgh
force-pushed
the
multi_not_string_pointer
branch
from
d0e10ee
to
221682e
Compare
jholdstock
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the SubmitWork function to take the submission directly instead of a pointer to it.
Strings are already reference types, so there is no reason to take a pointer to a string unless the calee intended to change what the caller's string points at. Moreover, taking a pointer could also lead to unnecessary allocations.