binance: move binance to separate package and add lot size utility #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
./lotsizes --global
LTCBTC: 100000 litoshi (0.00100000 LTC)
LTCETH: 100000 litoshi (0.00100000 LTC)
DOGEBTC: 100000000 Sats (1.00000000 DOGE)
ETHBTC: 100000 gwei (0.000100000 ETH)
POLETH: 100000000 gwei (0.100000000 MATIC)
MATICETH: 100000000 gwei (0.100000000 MATIC)
DASHBTC: 100000 Sats (0.00100000 DASH)
MATICBTC: 100000000 gwei (0.100000000 MATIC)
DCRBTC: 100000 atoms (0.00100000 DCR)
POLBTC: 100000000 gwei (0.100000000 MATIC)
BCHBTC: 100000 Sats (0.00100000 BCH)
DGBBTC: 100000000 digiSatoshi (1.00000000 DGB)
DASHETH: 100000 Sats (0.00100000 DASH)
|
I cant use test binance on simnet anymore with these changes, getting the error |
I wonder why you don't have any USDT markets. Maybe deposits were disabled temporarily? Can someone check global again? |
Whoops. Fixed |
martonp
reviewed
Sep 29, 2024
|
|
||
| func mainErr() error { | ||
| var global bool | ||
| flag.BoolVar(&global, "global", false, "use Binance Global (binance.com)") |
There was a problem hiding this comment.
Flag should probably be "us" as global is more common, but nbd.
martonp
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a refactor and the utility described in #2960.