ui: use dcrdex branding in extension-mode #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
force-pushed
the
dex-branding-extension-mode
branch
2 times, most recently
from
bd39432
to
2c110cd
Compare
|
These changes look fine but I'm unable to build decrediton at all for some reason. Is it because I updated to go 1.23 or are you able to build? |
|
It's because you updated to 1.23. Decrediton is on an older commit still. |
buck54321
force-pushed
the
dex-branding-extension-mode
branch
from
2c110cd
to
3b54747
Compare
buck54321
added a commit
to buck54321/dcrdex
that referenced
this pull request
Aug 23, 2024
This was referenced Aug 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an option to use DCRDEX branding when running in "extension mode", e.g. embedded in Decrediton.