-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dcr: Allow ticket purchasing for rpc spv wallets. #2611
Comments
Maybe add a field to the |
I think this is what I initially suggested to @jrick but maybe we can now. |
just opened decred/dcrwallet#2305 which adds the result to getinfo. But also now I'm seeing that a similar field was already added to walletinfo, so I'm not sure if this is even needed (a "spv" field is set to true if it's currently syncing with the spv syncer). |
ah, this typo threw me off (spv instead of vsp...). Gonna close the above pr then since the issue is only about detecting vsp settings, afaict. |
srry... I do that a lot. |
|
@buck54321 I guess we need to use master to have those changes? I attempted to use master with the simnet harness but decred/dcrwallet#2340 is causing wallet sync to stop. |
@JoeGruffins dcrwallet has a 2.0.0 release now. Can you update the dep here? |
@buck54321 it looks like all of the vsp fee processing logic has been removed from the vspd repo and is internal to wallet again. |
The biggest blocker for this is that currently the
GetTickets
rpc call will not work over rpc with an spv wallet. That will need to be "fixed" over in dcrwallet. The second problem is that, if a vsp is not set, purchasing will fail, and we currently have no way to know if anspvvsp is set. If it's ok to just fail sometimes, maybe with a message asking the user to make sure a vsp is set, then maybe that's fine. Maybe we can also add some data toGetTickets
or a new command to see if a vsp is currently set.The text was updated successfully, but these errors were encountered: