Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup empty scenes build #6176

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

ProteanCoding
Copy link

What does this PR change?

Removal from the repository of the temporary Empty Scenes build files.

@ProteanCoding ProteanCoding changed the title Chore/cleanup empty scenes build Cleanup empty scenes build Apr 18, 2024
@@ -46,7 +46,7 @@ node_modules/
npm-debug.log
.DS_Store
static/dist
public/systems
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder is no longer present

@ProteanCoding ProteanCoding marked this pull request as ready for review April 18, 2024 17:37
@aixaCode
Copy link
Collaborator

How are you testing those changes? You would need to provide a bit more context why are you proposing this change
As far as I understand those empty scenes are still used, and you can't remove them

@ProteanCoding
Copy link
Author

ProteanCoding commented Apr 19, 2024

This is meant as a follow-up to #6175.
The empty-scenes are created during the build process.
The temporary files removed in this PR appear to have been left-over from a previous build (and are therefore stale !)

@@ -46,7 +46,7 @@ node_modules/
npm-debug.log
.DS_Store
static/dist
public/systems
public/empty-scenes/common/contents
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ends up containing what are in fact temporary build files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants