[DO NOT MERGE] Comms Rooms for each scene #6024
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More
|
gonpombo8
commented
Dec 15, 2023
gonpombo8
force-pushed
the
feat/comms-scene
branch
from
9bad65c
to
b02aaf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
...
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
🤖[deprecated] Generated by Copilot at 1e9fd7a
This pull request adds a new feature to the comms module that allows users to communicate with each other in different scenes based on their parcel positions. It also improves the logging and code style of the comms module and its dependencies. It modifies the
comms,scene-loader, andworldmodules, and affects the following files:actions.ts,rfc-4-room-connection.ts,reducer.ts,sagas.ts,selectors.ts,types.ts,SceneWorker.ts,handlers.ts,genesis-city-loader-impl/index.ts, andscene-loader/sagas.ts.