feat: SDK7 implement ADR-245 (player components)

[leanmendoza]

This is a PoC to demonstrate the implementation of ADR-245 is possible with current state of renderer.

What?

Implements https://adr.decentraland.org/adr/ADR-245

Implemented and tested:

• Unique Entity each player
• Recycle entity numbers in the range
• Pointer Events
• Emotes
• Transform updates only in the scene where they are (otherwise null/delete component)
• Profile changed
  • implemented
  • fix bug: isn't working on preview

[github-actions]

After the CI passes:

Web

This branch can be previewed at:

• https://play.decentraland.org/?explorer-branch=feat/implement-sdk7-avatar-components
• https://play.decentraland.zone/?explorer-branch=feat/implement-sdk7-avatar-components

Desktop:

If you have the launcher installed (download launcher) you can press open on the following link:

• Open custom protocol
• Open custom protocol with Developer Mode

SDK 6/7:

• Open SDK7 scenes playground
• Open SDK7 scenes in preview
• Open SDK6 scenes in preview

More

• Code coverage report: https://renderer-artifacts.decentraland.org/branch-coverage/feat/implement-sdk7-avatar-components
• Benchmark report: https://renderer-artifacts.decentraland.org/branch-benchmark/feat/implement-sdk7-avatar-components/index.html

[gonpombo8]

what about the perf of this when we have many users on multiple scenes ?
Does it affects in something ? It seems costly but im not sure

[gonpombo8]

cant we use @dcl/sdk here so we avoid duplicating all these files ?
And use the ones that are already tested ?

[leanmendoza]

Absolutely we can, I didn't try to iterate fast, this is not going to be implemented by me, only giving a PoC to show it could work

[gonpombo8]

this is kind of a limitation right ? We can't support more that 190 users 🤔 ?
What when we have the sdk7 avatar scene and foreing entities ? How this two things are going to live together ?

[leanmendoza]

Actually, the range defined in the ADR is from 32 to 256 (224 players limit). AFAIK, the current limit in the Foundation client is 100 players. I'm not sure how realistic it is to think about more than 224 players but the ADR-245 is in Review state and comments and modifications are welcome.
Regarding the foreign entities, I'm not sure about how they and this are going to live together as I don't know what is the ETA to get the foreign entities a fact. The first (and original) idea was to do this with the Foreign entities (in the Protocol Squad), but due to the complexity and the scope of this, we decided to move with this approach.

Bevy and Godot implementation doesn't have a JavaScript Scene for avatars, and probably Explorer-Alpha goes with that approach, it'd be embedded in the explorer itself.

[leanmendoza]

what about the perf of this when we have many users on multiple scenes ? Does it affects in something ? It seems costly but im not sure

Each player is only in one Scene, so the Transform is only sent to it. I don't see any perf issue but we'd need to do some tests.