Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mapping completion criteria #769

Merged
merged 3 commits into from
Aug 30, 2024
Merged

fix: Mapping completion criteria #769

merged 3 commits into from
Aug 30, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

This PR changes the mapping completion criteria:

  • Collections that contain items that are not published and have migrations that are not set will be marked as incomplete.
  • Items will be marked as having an incomplete mapping if they have a curation (they were published) and it's flagged as not having its mappings as complete or if they don't have mappings set.

@coveralls
Copy link

coveralls commented Aug 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10622637667

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 71.305%
Totals Coverage Status
Change from base Build 10618325906: -0.03%
Covered Lines: 3094
Relevant Lines: 4185
💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit d3309e7 into master Aug 30, 2024
4 checks passed
@LautaroPetaccio LautaroPetaccio deleted the fix/mapping-collection-completion branch August 30, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyaiox cyaiox cyaiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LautaroPetaccio @coveralls @cyaiox