Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Dependencies #1030

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Plugin Dependencies #1030

wants to merge 2 commits into from
+115 −3

Conversation

alMukaafih
Copy link

No description provided.

bajrangCoder
bajrangCoder reviewed Sep 10, 2024
View reviewed changes
src/lib/installPlugin.js
const version = await isInstalled(id);
if (remoteDependency?.version === version) return false;

plugin = Object.assign({}, remoteDependency);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess you forget to define this variable

@bajrangCoder
Copy link
Collaborator

bajrangCoder commented Sep 10, 2024 •
edited
Loading

have you tested it? It doesn't work.
You need to properly handle the paid plugin cases etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajrangCoder bajrangCoder bajrangCoder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alMukaafih @bajrangCoder