-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sshfs date bug #4
Comments
This seems problematic for sure, I will have a look. No promises though! |
Thanks for accepting the challenge 😃 |
Happening in Fedora 36 as well:
|
Here I have some more Enterprise Linuxes from which I have mounted my home-dir to my Macbook with
|
I think the message/mechanism that's supposed to set file attributes is I added a hex dump debug function to dump out the iov and it shows this dump when I run
When I run
This is the difference:
From a first glance of the hex dumps, it seems the 1970 date ( File attributes (ATTR) are described in section 7
I have pushed the hex dumping when debugging (
there may be some sort of off-by-N bug in either SSHFS or SFTP or FUSE that made timestamps represented as seconds from Jan 1 1970 00:00:01 / 00:01:00 /.. or something like that and your edge cases threw them off. It's not a critical bug, but it might have interesting security implications if time is used to actually do something important over SSHFS. I'll leave this open as I keep digging a bit more. |
I already played around a little bit with the timestamps and I think I found already interesting timestamps as listed above… 🤔 (resulting in now and a future date) |
@h4sh5 , have you had the time to investigate further on this? |
I've another example (caused by a typo when touching a file in a bad script) - local file:
vs. remote:
|
Hi @deadbeefsociety and @h4sh5,
I really understand and I have the utmost understanding that unless I'm including a pull request or are reporting a critical issue, I might or even will probably not get a response for my low-impact issues.
But maybe you find my BUG interesting enough to have a look at it.
This bug has already been on libfuse#44 but has been closed unsolved.
This happens on Ubuntu 22.04.1 LTS…
and on openSUSE Leap 15.4 with the following versions:
On my Macbook (Ventura 13.1) and these versions…
it's also wrong with the slight difference, that
197001010100
doesn't results in "now" but in the right date.I’m really far away from programming, my last programming was some decades ago in my computer science /system programming studies, so maybe I've aroused your interest and you can help me fixing this because I'm in the need to work with these very old timestamps to represent my data from "a long time ago" correct?
The text was updated successfully, but these errors were encountered: