add IPN signal for failed payments in subscription #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PayPal sends the Subscription ID as "recurring_payment_id" for transaction types = recurring_payment_*, and as "subscr_id" for transaction types = subscr_* This follows on the everlasting ambiguity PayPal uses to call recurring payments. Transaction examples: * subscription created, cancelled, payment -> txn_type = subscr_* * subscription suspended, suspended due to tryout -> txn_type = recurring_payment_*
Indicate the datetime format of all DateTimeFields so they can be correctly parsed. This change is made in particular for retry_at. When users create a subscription which later fails an instalment, paypal issues an IPN event with txn_type='subscr_failed' which indicates the date of the next attempt. This event failed parsing by django-paypal, and gets stored into the database with raw content and a flag. This fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a signal for PayPal notifying via IPN that a user's subscription failed a payment. This notification is crucial to respond to, because the event normally results in PayPal shortly discontinuing the subscription and the bussiness losing the customer.