Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 1.0.0 release? #182

Open
shakefu opened this issue Jan 24, 2024 · 4 comments
Open

Cut 1.0.0 release? #182

shakefu opened this issue Jan 24, 2024 · 4 comments

Comments

@shakefu
Copy link

shakefu commented Jan 24, 2024

It looks like there's been a lot of changes since the 0.3.0 release that's available on PyPI (and tagged in this repo) - is it time to cut a 1.0.0 release? The documentation seems to be diverging significantly from the actual code on 0.3.0

@dcermak
Copy link
Owner

dcermak commented Jan 25, 2024 via email

@shakefu
Copy link
Author

shakefu commented Jan 28, 2024

Could you point me at documentation discrepancies? That shouldn't happen!

I just meant that the docs seem to be built off main and so contain things added since the 0.3.0 cut. I think the first place I noticed it was one of the extra args params to Container(...)... can't recall off the top of my head which one.

@dcermak
Copy link
Owner

dcermak commented Jan 28, 2024

Ah, I understand. I'll look into integrating the doc publishing into readthedocs, that should keep previous versions around.
Also, I'll try to cut a new release and work towards a 1.0. But I'd first like to get rid of the current multistage container implementation. And also find a way to test entry points better.

@martinpitt
Copy link

martinpitt commented Mar 14, 2024

I just stumbled over https://dcermak.github.io/pytest_container/api.html#pytest_container.container.Container promising extra_entrypoint_args, which was added in bb4f3e4 . But it's not present in the current version that you get with pip install, so there's no way to run a container with arguments.

Update: I found a hack: Start the container with entry_point=EntrypointSelection.BASH, and then run the real workload in the background with logs of shell salad:

        launcher.pod_data.container_data[1].connection.run_expect(
            [0], '(nohup minio server /data --console-address :9001 </dev/null >/tmp/minio.log 2>&1 &)')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants