Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zb: Re-export zvariant types & macros directly #807

Open
zeenix opened this issue May 23, 2024 · 1 comment
Open

zb: Re-export zvariant types & macros directly #807

zeenix opened this issue May 23, 2024 · 1 comment
Labels
enhancement New feature or request zbus Issues/PRs related to zbus crate zvariant Issues/PRs related to zvariant crate

Comments

@zeenix
Copy link
Contributor

zeenix commented May 23, 2024

I don't see why users have to access (or even know about in most cases) zvariant (as in zbus::zvariant). We should just directly export the relevant API from zvariant under zbus. This will hopefully also further discourage people from using zvariant directly and sometimes ending up with incompatible combo of zbus and zvariant.
@zeenix zeenix added enhancement New feature or request zbus Issues/PRs related to zbus crate zvariant Issues/PRs related to zvariant crate labels May 23, 2024
zeenix added a commit to zeenix/zbus that referenced this issue Jun 1, 2024
@zeenix
🚧 Towards zvariant symbols directly under zbus dbus2#807
25b9309 
WIP. Only hurdle is `zvariant_utils::def_attrs not supporting multiple attributes.
@zeenix zeenix mentioned this issue Jun 2, 2024
Open
@zeenix zeenix mentioned this issue Sep 14, 2024
Merged
@zeenix zeenix closed this as completed in c125ce2 Sep 15, 2024
vially pushed a commit to vially/zbus that referenced this issue Sep 23, 2024
@turbocool3r @vially
🚸zd: Allow zbus attribute in macros.
842e988 
Needed to resolve dbus2#807.
@zeenix
Copy link
Contributor Author

zeenix commented Oct 9, 2024

LOL, "resolve #807" in commit message of 842e988 ended up closing this.

Although while implementing this, I realized that exposing all the API directly under zbus really makes the crate root very croweded, with most types there foreign to zbus. So I'm no longer sure, this is a great idea. 🤔

@zeenix zeenix reopened this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request zbus Issues/PRs related to zbus crate zvariant Issues/PRs related to zvariant crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zeenix