Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-1834] [Feature] Add new fields to dbt-jsonschema #1071

Open
3 tasks done
Jstein77 opened this issue Mar 11, 2024 · 0 comments
Open
3 tasks done

[SL-1834] [Feature] Add new fields to dbt-jsonschema #1071

Jstein77 opened this issue Mar 11, 2024 · 0 comments
Labels
enhancement New feature or request linear triage Tasks that need to be triaged

Comments

@Jstein77
Copy link
Contributor

Jstein77 commented Mar 11, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

We need to update the dbt-jsonschema with new fields added to the spec. A community member flagged the following issues:

Hi Team,
Does the dbt YAML validator json at https://github.com/dbt-labs/dbt-jsonschema need to be updated for the latest? I'm looking at github.com/dbt-labs/jaffle-sl-template and see things not described in any of the validator schemas.
Examples:

  • File models/marts/customer360/orders.yml contains metric orders_fill_nulls_with_zero with type_params including fill_nulls_with and join_to_timespine not found in validation schemas
  • File models/marts/customer360/orders.yml contains metric twice_orders_fill_nulls_with_0 with type_params > metrics as a string. In the validation schemas it is an object with properties
  • File models/marts/ecommerce/olist_closed_deals.yaml contains metric mql_to_seller_conversion_rate_7_day_window_with_filter with conversion_type_params not found in validation schemas
  • File models/marts/ecommerce/olist_closed_deals.yaml contains metric mql_to_seller_conversion_rate_base with type: conversion which is not an expected enum value for type
  • File models/marts/customer360/order_items.yml contains saved_queries not found in validation schemas

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

SL-1834

@Jstein77 Jstein77 added enhancement New feature or request triage Tasks that need to be triaged labels Mar 11, 2024
@Jstein77 Jstein77 changed the title [Feature] Add new fields to dbt-jsonschema [SL-1834] [Feature] Add new fields to dbt-jsonschema Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linear triage Tasks that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant