Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-1617] [Feature] Enable time constraints with agg_time_dimension instead of metric_time #1008

Open
3 tasks done
courtneyholcomb opened this issue Jan 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request Medium priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync

Comments

@courtneyholcomb
Copy link
Contributor

courtneyholcomb commented Jan 26, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Currently, time constraints only work when queried with metric_time. Since metric_time represents agg_time_dimension, you should be able to replace metric_time with the agg_time_dimension and get the same behavior.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

SL-1617

@courtneyholcomb courtneyholcomb added enhancement New feature or request triage Tasks that need to be triaged labels Jan 26, 2024
@courtneyholcomb courtneyholcomb changed the title [Feature] Enable time constraints with agg_time_dimension instead of metric_time [SL-1617] [Feature] Enable time constraints with agg_time_dimension instead of metric_time Jan 26, 2024
@courtneyholcomb courtneyholcomb added the Metricflow Created by Linear-GitHub Sync label Jan 29, 2024
@courtneyholcomb courtneyholcomb added the Metricflow Gap Created by Linear-GitHub Sync label Jan 29, 2024
@courtneyholcomb courtneyholcomb self-assigned this Jan 29, 2024
@Jstein77 Jstein77 removed the triage Tasks that need to be triaged label Jan 31, 2024
@courtneyholcomb
Copy link
Contributor Author

@jordan.stein this isn't in progress yet!

@courtneyholcomb
Copy link
Contributor Author

@jordan.stein also - why high priority? time constraint params are only supported in the MF CLI, not any of our APIs, so this seems like a lower prio!

@courtneyholcomb courtneyholcomb added the Medium priority Created by Linear-GitHub Sync label Feb 1, 2024
@courtneyholcomb courtneyholcomb removed this from the MEtricflow Gaps Q1 milestone Feb 1, 2024
@courtneyholcomb courtneyholcomb added Metricflow Created by Linear-GitHub Sync and removed Metricflow Created by Linear-GitHub Sync Metricflow Gap Created by Linear-GitHub Sync labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants