Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-726] [Feature] Remove references to pg catalogs in hard-coded queries #555

Open
3 tasks done
Tracked by #776 ...
jiezhen-chen opened this issue Jul 25, 2023 · 3 comments · Fixed by #899
Open
3 tasks done
Tracked by #776 ...

[ADAP-726] [Feature] Remove references to pg catalogs in hard-coded queries #555

jiezhen-chen opened this issue Jul 25, 2023 · 3 comments · Fixed by #899
Assignees
Labels
enhancement New feature or request

Comments

@jiezhen-chen
Copy link
Contributor

jiezhen-chen commented Jul 25, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-redshift functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Migrate away from using pg_ catalogs in hard-coded sql queries. If there is an existing redshift API call, leverage the redshift driver to fetch the data. Alternatively, re-write the hard-coded sql queries to use standardized data discovery catalogs such as information_schema.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@jiezhen-chen jiezhen-chen added enhancement New feature or request triage labels Jul 25, 2023
@github-actions github-actions bot changed the title [Feature] Remove references to pg catalogs and svv tables in hard-coded queries [ADAP-726] [Feature] Remove references to pg catalogs and svv tables in hard-coded queries Jul 25, 2023
@alison985
Copy link

I don't think we want to get rid of svv mentions at the least.

These seem to be the latest on this issue: See dbt-labs/dbt-core#17 dbt-labs/dbt-utils#752 dbt-labs/dbt-postgres#53

@jiezhen-chen when searching on this issue I think I saw you do a PR in relation to these issues, so please correct my understanding if I'm missing something. Or perhaps the description of this issue would benefit from an update for clarity?

@jiezhen-chen jiezhen-chen changed the title [ADAP-726] [Feature] Remove references to pg catalogs and svv tables in hard-coded queries [ADAP-726] [Feature] Remove references to pg catalogs in hard-coded queries Aug 9, 2023
@jiezhen-chen
Copy link
Contributor Author

@alison985 you're right. Updated the description of this issue.
We're migrating away from using pg_ catalog tables as Redshift has migrated away from postgres. Instead, we're going to leverage information_schema, native redshift tables, or redshift_connector API calls.

@dataders dataders removed the triage label Aug 31, 2023
@nathaniel-may nathaniel-may added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Jan 10, 2024
@mikealfare mikealfare removed the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Aug 9, 2024
@mikealfare
Copy link
Contributor

I'm re-opening this; we only resolved one piece so far, get_columns_in_relation.

@mikealfare mikealfare reopened this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment