Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation: discount time spent building attack string #52

Open
davisjam opened this issue Jul 3, 2018 · 0 comments
Open

validation: discount time spent building attack string #52

davisjam opened this issue Jul 3, 2018 · 0 comments

Comments

@davisjam
Copy link
Owner

davisjam commented Jul 3, 2018

Currently the timeout is applied on a process level. In some languages building a long query string is expensive and can lead to a timeout, although the regex match itself is fast.

A fix would be to have the callee indicate to the caller when it is beginning the regex match so that the caller can start a timeout then.

I do not think any of the languages currently supported in this repository have slow string building times, since they are all "scripting" languages that prioritize string operations. However, I have a work-in-progress C# version that does have this problem. At any rate, to avoid false positives the fix indicated above should be applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant