Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select number value when a user begins typing while the dropdown is open #79

Open
heathercodes opened this issue Apr 5, 2018 · 2 comments

Comments

@heathercodes
Copy link

While this library is fantastic for words, when dropdown has numbers as the dropdown values and the user types a number value to search for it, the dropdown does not highlight that number.

e.g. in a dropdown list of birth years [2004... 1932], when the dropdown is open and the user types "1984", that value is not highlighted.

The reason for this may be addressed elsewhere, but wanted to file an issue to ask for clarification on this.

@davidtheclark
Copy link
Owner

I think the only reason for this is that it hasn't been implemented yet. Over in the dependency focus-group, I limited the keyboard listeners to letter keys: https://github.com/davidtheclark/focus-group/blob/b9de0536aa9b065b110a3880650f83e925ceef13/index.js#L133-L134 I wanted to avoid dealing with all the non-letter keys, but didn't think about numbers! So I think we'd need to make a change in focus-group, then update that dependency here.

@heathercodes
Copy link
Author

Thanks for the response David! It would be great to have this functionality on our app as we use a lot of number dropdowns and are trying to be AA accessible.

lekoaf added a commit to lekoaf/focus-group that referenced this issue Mar 5, 2019
Fixes davidtheclark/react-aria-menubutton#79

Change-Id: Ic59e59a87f59f4b2854aa07728cbffba6411b63b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@davidtheclark @heathercodes and others