Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks #31

Open
davidmoten opened this issue Jun 11, 2015 · 3 comments
Open

Benchmarks #31

davidmoten opened this issue Jun 11, 2015 · 3 comments

Comments

@davidmoten
Copy link
Owner

Benchmarks would be nice to help make performance improvements.

I propose to use JMH with some benchmarks that allow us to compare using straight jdbc patterns (lots of try-catch-finally } to using rxjava-jdbc. I would probably use embedded H2 database as per unit tests but open to suggestions.

@sparty02
Copy link
Contributor

👍 after reading this, I was actually going to say that I've had good experiences with the JUnitBenchmarks project, but it looks like they've deprecated it in favor of JMH, so all the better.

On a somewhat related note, your the JDBC patterns referenced in the docs (and in these benchmarks) should probably use try-with-resources. It really shouldn't make a performance difference as it's primarily syntactic sugar, but I think it better represents modern JDBC patterns.

@davidmoten
Copy link
Owner Author

Thanks for your suggestion about using try-with-resources in the README. Makes sense especially as the library requires java 7. I'll update it and use that pattern in benchmarks.

@davidmoten
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants