You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Benchmarks would be nice to help make performance improvements.
I propose to use JMH with some benchmarks that allow us to compare using straight jdbc patterns (lots of try-catch-finally } to using rxjava-jdbc. I would probably use embedded H2 database as per unit tests but open to suggestions.
The text was updated successfully, but these errors were encountered:
👍 after reading this, I was actually going to say that I've had good experiences with the JUnitBenchmarks project, but it looks like they've deprecated it in favor of JMH, so all the better.
On a somewhat related note, your the JDBC patterns referenced in the docs (and in these benchmarks) should probably use try-with-resources. It really shouldn't make a performance difference as it's primarily syntactic sugar, but I think it better represents modern JDBC patterns.
Thanks for your suggestion about using try-with-resources in the README. Makes sense especially as the library requires java 7. I'll update it and use that pattern in benchmarks.
Benchmarks would be nice to help make performance improvements.
I propose to use JMH with some benchmarks that allow us to compare using straight jdbc patterns (lots of try-catch-finally } to using rxjava-jdbc. I would probably use embedded H2 database as per unit tests but open to suggestions.
The text was updated successfully, but these errors were encountered: