Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accent Positioning Roman lowercase /dotbelow #14

Closed
pichotta opened this issue Nov 14, 2019 · 3 comments
Closed

Accent Positioning Roman lowercase /dotbelow #14

pichotta opened this issue Nov 14, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@pichotta
Copy link
Collaborator

/dotbelow is migrating across weight

also, in the lightweight Italic
this /aacute issue appears in the currently served fonts
but please align it because it differs from other lc accent positioning

:dotbelow

:aacute

@pichotta pichotta added the bug Something isn't working label Nov 14, 2019
@djrrb
Copy link
Collaborator

djrrb commented Nov 14, 2019

@pichotta I believe the dotbelow thing is similar to the tilde issue, because the dot below is a component.

I still think this is a bug in fontmake or diffenator, as the source data with a component of a component should be okay. But if you’d prefer for me to just decompose, let me know.

@pichotta
Copy link
Collaborator Author

@djrrb yes, please resolve in same way as tilde

@djrrb
Copy link
Collaborator

djrrb commented Nov 18, 2019

The accent heights are all over the place in this font, and aligning everything seemed like it would be going too far. But I did offset the acute across styles.

As far as the dot below, I think we can let fontmake solve this. If we need an immediate solve, we can add these glyphs to the lib, but I think it’s cleaner to let them update the tool to do this automatically than to store the extra data. googlefonts/fontmake#595 (comment)

@djrrb djrrb closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants