Update to allow for platform dependent libs in CGO #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoney
commented
Jun 4, 2024
jmoney
commented
Jun 4, 2024
jmoney
commented
Jun 4, 2024
jmoney
commented
Jun 4, 2024
This was referenced Jun 4, 2024
|
hm interesting, let me test it in a larger repo, see how it works before merging |
jmoney
commented
Jun 6, 2024
|
hey @daulet , so what do you think of this PR? Do you believe it allows more ease of use of these bindings that we can merge and release? |
Yes, I think making this build time parameter satisfies all use cases, however i find it annoying to specify LD flags every time i |
|
i suppose we could just use |
daulet
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies other go programs usage of this library. Currently, you have to copy the
libtokenizers.afile to$(go env GOMODCACHE)/daulet/tokenizers@${version}. The change here forces the user to specify where to load this library from instead of it being required to be at a certain place.