Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Require Display Name as Input; Don't require Name #1106

Open
golanglemonade opened this issue Jul 9, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@golanglemonade
Copy link
Contributor

golanglemonade commented Jul 9, 2024

Summary

The Name field is (and should remain) unique, but we don't necessarily want to require the user to set it.
The Display Name is what the user should enter as input, and it is not required to be unique in our system.

Part 1:

The schema should be updated to be Optional() and NotEmpty() for both fields, e.g.:

Updated Organization Schema:

			Comment("the name of the organization").
			MaxLen(orgNameMaxLen).
                         ++ Optional().
			NotEmpty().
			Annotations(
				entgql.OrderField("name"),
				entgql.Skip(entgql.SkipWhereInput),
			),
		field.String("display_name").
			Comment("The organization's displayed 'friendly' name").
			MaxLen(nameMaxLen).
                        ++  Optional().
		       ++ NotEmpty().
			Annotations(
				entgql.OrderField("display_name"),
			),

Part 2

If the Name isn't provided, we should come up with a good format so that it remains human readable + unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants