Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ordering of tables and relationship #84

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Feb 9, 2024

resolves #80

Description

Ensure ordering of tables and relationships. This will allow CI/CD to suppress unnecessary differential output when automatically generating documents.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@syou6162 syou6162 force-pushed the feature/ensure_order_of_tables_and_relationships branch from 3bda29d to 6f4cffc Compare February 9, 2024 16:44
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6cf5f4) 85.68% compared to head (6f4cffc) 100.00%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##             main       #84       +/-   ##
============================================
+ Coverage   85.68%   100.00%   +14.31%     
============================================
  Files          31        31               
  Lines         915       915               
============================================
+ Hits          784       915      +131     
+ Misses        131         0      -131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syou6162 syou6162 marked this pull request as ready for review February 9, 2024 16:49
@datnguye datnguye merged commit c6f27fc into datnguye:main Feb 10, 2024
12 checks passed
@datnguye
Copy link
Owner

Nice & very simple change! 🎉

@syou6162 syou6162 deleted the feature/ensure_order_of_tables_and_relationships branch February 10, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Ensure that the order of tables and relationships in the output diagram does not change each time
2 participants