Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update relationship_type.md #60

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Update relationship_type.md #60

merged 1 commit into from
Dec 6, 2023

Conversation

tjirab
Copy link
Contributor

@tjirab tjirab commented Nov 15, 2023

This test got renamed to relationships (tested in 1.6.2).

resolves #

Description

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

This test got renamed to `relationships` (tested in 1.6.2).
@datnguye
Copy link
Owner

Hi @tjirab Nice, thanks for this update!
I notice Draft status, is the PR ready now? Let me know if it is so that I can merge and trigger the docs site pipeline

@datnguye
Copy link
Owner

Hi @tjirab Is there any updates on this? Thanks

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0da8c8) 100.00% compared to head (cfef397) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         1135      1135           
=========================================
  Hits          1135      1135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datnguye datnguye marked this pull request as ready for review December 6, 2023 02:02
@datnguye datnguye merged commit ba62236 into datnguye:main Dec 6, 2023
12 checks passed
@tjirab
Copy link
Contributor Author

tjirab commented Feb 15, 2024

@datnguye Apologies, I totally missed your comment. Thanks for merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants