Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/49 add dbt selection #50

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Conversation

datnguye
Copy link
Owner

@datnguye datnguye commented Sep 8, 2023

resolves #49

Allow to reuse dbt Selection leveraging dbt Programmatic Invocation, with having the addtional options:

  • --dbt
  • --dbt-project-dir
  • --dbt-target

For example, generate ERD selecting model named 'abc' upstreaming:

cd your/dbt/project
dbt docs gerenrate
dbterd run -s +abc --dbt

NOTE:
The following command will failed to Unsupported Selection, because it will use dbterd's Selection:

dbterd run -s +abc

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@datnguye datnguye self-assigned this Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #50 (5e26429) into main (6813ab0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main       #50    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           41        43     +2     
  Lines          917      1092   +175     
==========================================
+ Hits           917      1092   +175     
Files Changed Coverage Δ
dbterd/adapters/adapter.py 100.00% <ø> (ø)
dbterd/adapters/algos/base.py 100.00% <100.00%> (ø)
dbterd/adapters/algos/test_relationship.py 100.00% <100.00%> (ø)
dbterd/adapters/base.py 100.00% <100.00%> (ø)
dbterd/adapters/dbt_invocation.py 100.00% <100.00%> (ø)
dbterd/adapters/filter.py 100.00% <100.00%> (ø)
dbterd/adapters/meta.py 100.00% <100.00%> (ø)
dbterd/cli/main.py 100.00% <100.00%> (ø)
dbterd/cli/params.py 100.00% <100.00%> (ø)
...ests/unit/adapters/algos/test_test_relationship.py 100.00% <100.00%> (ø)
... and 10 more

📢 Have feedback on the report? Share it here.

@datnguye datnguye merged commit bed433d into main Sep 8, 2023
12 checks passed
@datnguye datnguye deleted the feature/49-add-dbt-selection branch September 8, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Include all refs when rendering a single model
1 participant