Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue about "gpt.py" in code part of ch 4 #50

Open
976213951 opened this issue Nov 6, 2024 · 1 comment
Open

issue about "gpt.py" in code part of ch 4 #50

976213951 opened this issue Nov 6, 2024 · 1 comment

Comments

@976213951
Copy link

976213951 commented Nov 6, 2024

In the line 66, it is supposed to be "nn.Linear(d_out, d_in)" instead of "nn.Linear(d_out, d_out)" since the linear attempts to project the dimension of the attention (d_out) back to the dimension of embedding "d_in". However, this code can work without any error report because the "d_out" is set equal to "d_in" by default.

@HeiBoWang
Copy link

HeiBoWang commented Nov 6, 2024 via email

@976213951 976213951 changed the title issue about "gpt.py" in he code part of ch 4 issue about "gpt.py" in code part of ch 4 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants