You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For some reason, the name "12society" is identified as "CorporationNameOrganization" by the parse function when using the "company" model/tagger. I don't know the details of the trained model, but it spits out things other than "CorporationName" which is a problem: the tagged OrderedDict doesn't contain a key "CorporationName" but it definitely is not a person!
I added this to the conditional to set the name_type to 'Corporation':
any(s.find("Corporation") >= 0 for s in tagged)
I'd generate a PR but it's ugly and I don't know what other outputs to expect from the parse function. Any help is appreciated!
import probablepeople
probablepeople.tag("12society")
Out[2]: (OrderedDict([('Surname', '12society')]), 'Person')
probablepeople.tag("12society", "company")
Out[3]: (OrderedDict([('CorporationNameOrganization', '12society')]), 'Person')
# I then add my 'any(...)' code from above:
probablepeople.tag("12society", "company")
Out[4]: (OrderedDict([('CorporationNameOrganization', '12society')]), 'Corporation')
"P2 Science" is another name that pops up as CorporationNameOrganization
The text was updated successfully, but these errors were encountered:
I've been chasing down a bug I'm encountering in Dedupe (which uses probablepeople) and I traced it to this line:
probablepeople/probablepeople/__init__.py
Line 141 in 672075c
For some reason, the name "12society" is identified as "CorporationNameOrganization" by the parse function when using the "company" model/tagger. I don't know the details of the trained model, but it spits out things other than "CorporationName" which is a problem: the tagged OrderedDict doesn't contain a key "CorporationName" but it definitely is not a person!
I added this to the conditional to set the name_type to 'Corporation':
any(s.find("Corporation") >= 0 for s in tagged)
I'd generate a PR but it's ugly and I don't know what other outputs to expect from the parse function. Any help is appreciated!
"P2 Science" is another name that pops up as CorporationNameOrganization
The text was updated successfully, but these errors were encountered: