Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create automation tool that updates cookiecutter whenever a pypi or node package upgrades #354

Open
smcalilly opened this issue Dec 13, 2023 · 5 comments
Assignees

Comments

@smcalilly
Copy link
Contributor

smcalilly commented Dec 13, 2023

Similar to dependabot with security updates, we could create a github action that upgrades python and javascript dependencies for the django cookiecutter. This would obsolete the manual, tedious process where we upgrade those dependencies whenever we notice they're old (which isn't the best method).

Here's one downside to this approach: what if the bot upgrades the dependencies and the changes break something in the cookiecutter? For example, IIRC, in the past a React upgrade broke how we render the react components and we had to upgrade React + change something in the cookiecutter. To address this problem, we can review the changes with a review app deployed to heroku (fully automated by gh actions!), and add some automated tests to ensure all parts of the cookiecutter app still works.

Are there any other downsides to this?

@fgregg
Copy link
Member

fgregg commented Dec 13, 2023

i think some CI for the cookie cutter is brilliant.

@hancush
Copy link
Member

hancush commented Dec 13, 2023

I have used npm-check-updates for this exact task: https://www.npmjs.com/package/npm-check-updates

@xmedr
Copy link
Contributor

xmedr commented Apr 18, 2024

The new github workflow was merged in and successfully upgraded dependencies this past Sunday!

The concern about dependencies breaking each other makes sense. And I do like the idea of tests to make sure things still run well with the upgrades, but what would that look like?

@fgregg
Copy link
Member

fgregg commented Apr 19, 2024

as a one test, we could instantiate the cookie cutter instances and check that the main page loads?

@antidipyramid
Copy link
Contributor

@xmedr will try CI integration with Heroku/Github Actions next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants