Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to annotate and labels seq pods #9

Open
bravecobra opened this issue May 11, 2021 · 2 comments
Open

Add an option to annotate and labels seq pods #9

bravecobra opened this issue May 11, 2021 · 2 comments

Comments

@bravecobra
Copy link

It might be useful to add the option to label and annotate the different pods from the values.yaml. That enables service meshes like consul to autoinject sidecars through hooks.

@nblumhardt
Copy link
Member

Thanks for the suggestion 👍

@pinkfloydx33
Copy link

We also need the ability to add pod labels.

We are leveraging Azure Workload Identity for managed identity access to the metastore database. A new requirement for the feature (as it gets ready for GA) is a label added to each pod. To get around this we are using Helm's Kustomize post-processor to add the label, but it'd be nice for it to have first class representation in the chart.

Similarly, while we wait for Seq 2023.x (which includes the latest Azure.Identity and native support for AZWI) we must also annotate the pods to add a sidecar that enables AZWI for applications lacking first-class support. We have to use the same post-processor to add the annotation. While this is a temporary requirement for us, I can see the need to support annotations generally.

For now we'll continue to use the Helm post-processor but a thumbs up for supporting both labels and annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants