Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic data table on collection page #885

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 24, 2024

Closes #815
Closes #891.

Replaces the next table on collections with the new dynamic table, and:

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (1d63eb6) to head (95de17d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          62       62           
  Lines        3909     3909           
=======================================
  Hits         2667     2667           
  Misses       1242     1242           

Copy link

cypress bot commented Sep 24, 2024

datalab    Run #2431

Run Properties:  status check failed Failed #2431  •  git commit 8eed634ada ℹ️: Merge 95de17d1bc60ce3c43bc6978cfcbb921b444af24 into 1d63eb6ca5d9a76cefb663b0e639...
Project datalab
Branch Review ml-evs/add-collection-table
Run status status check failed Failed #2431
Run duration 06m 36s
Commit git commit 8eed634ada ℹ️: Merge 95de17d1bc60ce3c43bc6978cfcbb921b444af24 into 1d63eb6ca5d9a76cefb663b0e639...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 51
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 78
View all changes introduced in this branch ↗︎

Tests for review

Failed  batchSampleFeature.cy.js • 7 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Batch sample creation > modifies some data in the first sample Test Replay Screenshots
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Test Replay Screenshots
Batch sample creation > plays with the number of rows Test Replay Screenshots
Batch cell creation > creates a batch of cells using the template id, name, date, copyFrom, and components Test Replay Screenshots
Failed  editPage.cy.js • 6 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Edit Page > Checks editing the sample edit page Test Replay Screenshots
Edit Page > adds a chemical formula to component1 Test Replay Screenshots
Edit Page > adds some synthesis information Test Replay Screenshots
Edit Page > deletes synthesis components and re-adds them Test Replay Screenshots
Edit Page > tries to add a non-numeric value into quantity Test Replay Screenshots
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Test Replay Screenshots
Failed  equipment.cy.js • 1 failed test • End-to-end tests (chrome)

View Output

Test Artifacts
Equipment edit page > modifies some data in a sample Test Replay Screenshots
Failed  sampleTablePage.cy.js • 3 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Advanced sample creation features > modifies some data in the second sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample with components Test Replay Screenshots
Failed  batchSampleFeature.cy.js • 7 failed tests • End-to-end tests (firefox)

View Output

Test Artifacts
Batch sample creation > modifies some data in the first sample Screenshots
Batch sample creation > modifies some data in the second sample Screenshots
Batch sample creation > checks the copied samples Screenshots
Batch sample creation > checks the created samples Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Screenshots
Batch sample creation > plays with the number of rows Screenshots
Batch cell creation > creates a batch of cells using the template id, name, date, copyFrom, and components Screenshots

The first 5 failed specs are shown, see all 12 specs in Cypress Cloud.

@ml-evs ml-evs marked this pull request as ready for review September 27, 2024 17:11
@ml-evs ml-evs requested review from BenjaminCharmes and removed request for jdbocarsly September 27, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collections table incorrect link to collection edit page Collection table is currently broken
1 participant