-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic data table on collection page #885
Open
ml-evs
wants to merge
3
commits into
main
Choose a base branch
from
ml-evs/add-collection-table
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
=======================================
Coverage 68.22% 68.22%
=======================================
Files 62 62
Lines 3909 3909
=======================================
Hits 2667 2667
Misses 1242 1242 |
ml-evs
force-pushed
the
ml-evs/add-collection-table
branch
from
September 27, 2024 17:02
97a8685
to
bf89a07
Compare
… for collection edit page
…it for collections
ml-evs
force-pushed
the
ml-evs/add-collection-table
branch
from
September 27, 2024 17:10
bf89a07
to
95de17d
Compare
ml-evs
requested review from
BenjaminCharmes
and removed request for
jdbocarsly
September 27, 2024 17:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #815
Closes #891.
Replaces the next table on collections with the new dynamic table, and: