Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockfile compatibility #873

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Lockfile compatibility #873

merged 6 commits into from
Sep 4, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 4, 2024

This PR does the following:

  • begin migration to a uv-specific lockfile (uv.lock), pending its standardisation (we will keep using requirements files for the time being too)
  • update Pipfile.lock to have the same values as the requirements
  • add script to do this automatically in the future

This sees us basically move to a Pipfile-less setup.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (9501932) to head (78b2478).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          62       62           
  Lines        3890     3890           
=======================================
  Hits         2650     2650           
  Misses       1240     1240           

Copy link

cypress bot commented Sep 4, 2024

datalab    Run #2371

Run Properties:  status check passed Passed #2371  •  git commit 9508dc83d6 ℹ️: Merge 78b247869ffe7bc490724feaa6624f1969cca8e7 into 9501932e8bb12875ce9a7e950d1d...
Project datalab
Branch Review ml-evs/deps
Run status status check passed Passed #2371
Run duration 04m 43s
Commit git commit 9508dc83d6 ℹ️: Merge 78b247869ffe7bc490724feaa6624f1969cca8e7 into 9501932e8bb12875ce9a7e950d1d...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 132
View all changes introduced in this branch ↗︎

@ml-evs ml-evs added build For issues/PRs pertaining to the build or deployment of the package Python labels Sep 4, 2024
@ml-evs ml-evs merged commit 3924984 into main Sep 4, 2024
19 checks passed
@ml-evs ml-evs deleted the ml-evs/deps branch September 4, 2024 23:50
BenjaminCharmes pushed a commit that referenced this pull request Sep 11, 2024
* Add Pipfile.lock derived from requirements file

* Add uv.lock file

* Add upper pin of Python 3.12 for conflicting dependencies

* Add utility script for resyncing pipenv

* Remove Pipfile and add it to gitignore

* Update install instructions to avoid `pipenv install`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build For issues/PRs pertaining to the build or deployment of the package Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant