Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gpt-3.5-turbo series and handle missing models in chatblock #855

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Aug 20, 2024

Closes #834.

gpt-3.5-turbo are being turned off next month. This PR removes them from the chatblock, but allows old chats to default to the new default model.

Still need to do some local testing.

@ml-evs ml-evs added the datablock An issue pertaining to a specific datablock label Aug 20, 2024
@ml-evs ml-evs requested a review from jdbocarsly August 20, 2024 21:12
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.12%. Comparing base (6c764a7) to head (48ae523).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/pydatalab/apps/chat/blocks.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
- Coverage   68.14%   68.12%   -0.02%     
==========================================
  Files          62       62              
  Lines        3889     3890       +1     
==========================================
  Hits         2650     2650              
- Misses       1239     1240       +1     
Files with missing lines Coverage Δ
pydatalab/pydatalab/apps/chat/blocks.py 20.16% <0.00%> (-0.17%) ⬇️

Copy link

cypress bot commented Aug 20, 2024

datalab    Run #2352

Run Properties:  status check passed Passed #2352  •  git commit b218a44835 ℹ️: Merge 48ae52331adfae144d422ef33961763fff44988d into 6c764a770e2cf6fbe90058bfc15f...
Project datalab
Branch Review ml-evs/deprecate-gpt3
Run status status check passed Passed #2352
Run duration 04m 08s
Commit git commit b218a44835 ℹ️: Merge 48ae52331adfae144d422ef33961763fff44988d into 6c764a770e2cf6fbe90058bfc15f...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 132
View all changes introduced in this branch ↗︎

@ml-evs ml-evs marked this pull request as ready for review August 31, 2024 19:36
@ml-evs ml-evs merged commit 42b5c71 into main Aug 31, 2024
19 checks passed
@ml-evs ml-evs deleted the ml-evs/deprecate-gpt3 branch August 31, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datablock An issue pertaining to a specific datablock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate gpt-3.5 models
1 participant