Allow any authenticated user to generate an API key #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1121 ↗︎
Details:
Review all test suite changes for PR #641 ↗︎ |
|||||||||||||||
|
Self-merging this too as it should be a trivial change (and is already deployed...) |
BenjaminCharmes
pushed a commit
to BenjaminCharmes/datalab
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #639
Previously, only admins could request an API key. Now anyone can.
These keys do not currently expire, but they probably should -- we could add this by using jwt's directly as API keys, and then checking the expiry date on access.
As before, hitting the
/get-api-keyendpoint while logged in will refresh the key and remove the old one.