Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mail config settings #614

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Refactor mail config settings #614

merged 1 commit into from
Feb 23, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Feb 23, 2024

  • Updating testing to check this
  • Allow custom env files to be passed to create_app

Closes #612.

@ml-evs ml-evs force-pushed the ml-evs/email-config-refactor branch from 941de61 to 4f218cf Compare February 23, 2024 17:03
Copy link

cypress bot commented Feb 23, 2024

Passing run #1034 ↗︎

0 26 0 0 Flakiness 0

Details:

Merge db133d4 into d22a681...
Project: datalab Commit: 9094e2cc26 ℹ️
Status: Passed Duration: 01:31 💡
Started: Feb 23, 2024 5:36 PM Ended: Feb 23, 2024 5:38 PM

Review all test suite changes for PR #614 ↗︎

@ml-evs ml-evs force-pushed the ml-evs/email-config-refactor branch from 4f218cf to 9d68b4f Compare February 23, 2024 17:15
- Updating testing to check this
- Allow custom env files to be passed to `create_app`
@ml-evs ml-evs force-pushed the ml-evs/email-config-refactor branch from 2e40e51 to db133d4 Compare February 23, 2024 17:30
@ml-evs ml-evs merged commit c0a6458 into main Feb 23, 2024
8 checks passed
@ml-evs ml-evs deleted the ml-evs/email-config-refactor branch February 23, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMTP/Email auth configuration considered harmful
1 participant