Pin prettier version in Webapp to same version that is specified in pre-commit #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opment environment's version and pre-commit's version. Also explicitely specify trailingComma: all, to improve compatibility with different versions of prettier (should such differences persist)
Passing run #895 ↗︎
Details:
Review all test suite changes for PR #589 ↗︎ |
|||||||||||||||
ml-evs
pushed a commit
that referenced
this pull request
Feb 18, 2024
…re-commit (#589) * pin prettier version to ensure compatibility between the webapp development environment's version and pre-commit's version. Also explicitely specify trailingComma: all, to improve compatibility with different versions of prettier (should such differences persist) * update eslint-plugin-prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier has changed the way it formats code from version-to-version. So, to ensure that the weapp's version of prettier (invoked using
yarn lint) and pre-commit's don't clash, this pins the version.Also explicitely specifies
trailingComma: allin the.prettierrcto be explicity about which settings we are using.