Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seperator as a fully-fledged cell constituent #489

Closed
wants to merge 1 commit into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 31, 2023

Closes #487.

After discussion with @jdbocarsly, probably the advice is to include the separator as a component of the electrolyte. This PR will need to be updated to add this as part of the documentation in the UI (simple tooltip somewhere).

Copy link

cypress bot commented Oct 31, 2023

Passing run #491 ↗︎

0 44 0 0 Flakiness 0

Details:

Merge 53ff7b2 into e8bf107...
Project: datalab Commit: 1b9b85e3d4 ℹ️
Status: Passed Duration: 04:57 💡
Started: Oct 31, 2023 7:06 PM Ended: Oct 31, 2023 7:11 PM

Review all test suite changes for PR #489 ↗︎

@ml-evs ml-evs added the on-hold label Nov 1, 2023
@ml-evs ml-evs closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Add separator as cell component
1 participant