Native support for automatic backups #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/native-backups
branch
from
a330e77
to
cd2b8ed
Compare
ml-evs
force-pushed
the
ml-evs/native-backups
branch
from
cd2b8ed
to
5ff2ebe
Compare
ml-evs
force-pushed
the
ml-evs/native-backups
branch
4 times, most recently
from
3483fb9
to
abf336a
Compare
Passing run #722 ↗︎
Details:
Review all test suite changes for PR #467 ↗︎ |
|||||||||||||||
ml-evs
force-pushed
the
ml-evs/native-backups
branch
2 times, most recently
from
0568e86
to
91de6c6
Compare
ml-evs
force-pushed
the
ml-evs/native-backups
branch
from
5731d54
to
fbe56c4
Compare
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/native-backups
branch
7 times, most recently
from
e0fa3cc
to
a65d677
Compare
…ommit - [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci - pre-commit autoupdate
ml-evs
force-pushed
the
ml-evs/native-backups
branch
from
a65d677
to
a15398a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #464.
This PR provides the config, functionality and automation tasks for making and restoring backups of entire datalab instances. Configured backups can be synced with remote systems via SSH, and will handle backup retention (e.g., keeping
ncopies before removing them to save space). The default set of configured backups will locally backup daily (7 copies), weekly (4 copies) and quarterly (4 copies) for good coverage, and allows admins to configure additional remote backups instead.What this PR does not yet implement is scheduled backups, even though the config options are there. This will have to be handled in the future with APScheduler or something similar. For now, the invoke task for creating backups can be added to a local crontab or otherwise (though it is not recommended to do this inside the docker containers themselves).