Add UI for collections, fix local graphs and improve tables #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
enhancement
1 task
Passing run #392 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
Deployed this to dev, one note is that this seems to require some migration somewhere to work out. Will investigate tomorrow. |
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/collections_UI
branch
4 times, most recently
from
4d569b1
to
1b42f68
Compare
|
Going to merge this as-is as its been hanging around for ages, everything now works but I've removed collection blocks as they were requiring 100s of lines of UI duplication to get working -- better to add as a blocks refactor. |
ml-evs
force-pushed
the
ml-evs/collections_UI
branch
from
1b42f68
to
5a89fe3
Compare
- List collection membership in sample/cell pages - Add collections API connections and associated setters (move up) - Add collection type to resources - Add collections-related fields to store - Add ability to insert new item straight into an existing collection - Add simplified collections views - Add collection select component - Re-add sample table for collections - Make the collection sample table work by reworking the store - Add UI components for formatting collection names - Tweak formatted item names/refcode components to enable multiple on same line
…omponent - Also fix sizing type mismatch in `UserBubble`
- Add cypress and log dirs to gitignore - Refactor babel to only strip console in production
- Fix graph tests - Fix e2e tests again - One more tweak to e2e - Fix trailing slash
- Add collection nodes and edges to graph view - Fix local graph by properly dealing with bi-directional relationships - Add collection-level graphs - Fix local graph tests when using collections
ml-evs
force-pushed
the
ml-evs/collections_UI
branch
from
5a89fe3
to
21af81b
Compare
- Add special node type for the centre of a local graph - Default to graph view on item page - Tweak user bubbles
ml-evs
force-pushed
the
ml-evs/collections_UI
branch
2 times, most recently
from
9862dc9
to
b3bd5b8
Compare
Hmmm, still some spurious e2e failures, will investigate on dev later before merging |
- Remove mention of collection blocks in UI until later refactor
- Update cypress tests - Update starting material UI with collections list
ml-evs
force-pushed
the
ml-evs/collections_UI
branch
3 times, most recently
from
1d7f198
to
a9d9e8f
Compare
ml-evs
force-pushed
the
ml-evs/collections_UI
branch
from
a9d9e8f
to
d87faa5
Compare
|
This is finally ready -- still need to work on #423 but this is enough for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #292 by taking out the basic collections UI functionality of
Blocked by #403.
Buttons for adding old items to old collections(opened as Missing UI for adding/removing an existing item to a collection #423)