Improve login/logout UI to support multiple authentication mechanisms #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
enhancement
ml-evs
force-pushed
the
ml-evs/login_modal
branch
from
664b368
to
44cd693
Compare
Passing run #482 ↗︎
Details:
Review all test suite changes for PR #384 ↗︎ |
|||||||||||||||
ml-evs
force-pushed
the
ml-evs/login_modal
branch
from
44cd693
to
0983041
Compare
ml-evs
force-pushed
the
ml-evs/login_modal
branch
2 times, most recently
from
c7bbc73
to
e7cca16
Compare
ml-evs
force-pushed
the
ml-evs/login_modal
branch
from
e7cca16
to
8310ba7
Compare
ml-evs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors our simple login/logout button into two dropdowns, with state depending on whether the user is logged in.
If logged out, the "Login" button is a dropdown with links to login via GitHub/ORCID/email (currently disabled). If logged in, the "" button is a dropdown with links to account settings (currently disabled) and the logout button.