Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial issues to resolve with new data table #889

Open
5 of 9 tasks
ml-evs opened this issue Sep 26, 2024 · 2 comments
Open
5 of 9 tasks

Initial issues to resolve with new data table #889

ml-evs opened this issue Sep 26, 2024 · 2 comments
Assignees
Labels
priority/medium visuals For issues/PRs pertaining to visuals/aesthetics of the interface

Comments

@ml-evs
Copy link
Member

ml-evs commented Sep 26, 2024

  • The "select all" button is slow with lots of samples/inventory. Can we change the select button to only select the shown samples as a workaround?
  • Each individual checkbox has to be clicked precisely to be clicked. Can we change the @ click even to be on the cell, rather than on the checkbox
  • Tests for checking whether components are rendered in the table
  • Test for adding to inventory when editable_inventory is turned on etc
  • Check whether add to collection select on create new item modal still works
  • Consider future refactor around how components are specified in the table, i.e., whether they can be mapped from the datalab server schema
  • Wrapping of long columns
  • Enhanced filtering UI on fields with components #973
  • Item table search bar does nothing when filter is applied #992
  1. Is there a way to make the filter symbol filled in when a filter is on?
  2. "Add a collection" from the CollectionSelect is great, but the spinner seems to be broken as it never goes away even once the collection is created
  3. When you insert something into a collection, and then search for the same collection again, it gives you the option to create the collection again, and then causes an error.
  4. seems to be possible to "double add" something to a collection that was already in that collection, which causes an error when you try to access the page "relationships and collection mismatch"

Originally posted by @jdbocarsly in #862 (review)

@ml-evs
Copy link
Member Author

ml-evs commented Oct 9, 2024

Just unchecked the long column issue, seems like long names are split to multiple lines again in the latest version

@ml-evs ml-evs added the visuals For issues/PRs pertaining to visuals/aesthetics of the interface label Oct 12, 2024
@ml-evs
Copy link
Member Author

ml-evs commented Nov 6, 2024

Long columns are now fine, i.e., they dont have linebreaks, but columns like date are now just consistently too small. Fix suggested by @BenjaminCharmes: try resizable columns in Prime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium visuals For issues/PRs pertaining to visuals/aesthetics of the interface
Projects
None yet
Development

No branches or pull requests

2 participants