Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(query): simplify expression kernel #16482

Merged
merged 5 commits into from
Sep 20, 2024
Merged

refactor(query): simplify expression kernel #16482

merged 5 commits into from
Sep 20, 2024
+850 −1,158

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Sep 20, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

simplify expression kernel codes via ValueVisitor trait.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 20, 2024
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 20, 2024
@dosubot dosubot bot added the A-query Area: databend query label Sep 20, 2024
Dousir9
Dousir9 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@Dousir9 Dousir9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 20, 2024
@Dousir9 Dousir9 added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@Dousir9 Dousir9 added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 20, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 20, 2024
@BohuTANG BohuTANG merged commit a831c4b into datafuselabs:main Sep 20, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

@Dousir9 Dousir9 Dousir9 approved these changes

Assignees
No one assigned
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sundy-li @andylokandy @Dousir9 @BohuTANG