Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): make string to int respect behavior like PG #16428

Merged
merged 12 commits into from
Sep 12, 2024
Merged

chore(query): make string to int respect behavior like PG #16428

merged 12 commits into from
Sep 12, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Sep 10, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. reorder optimize rules
  2. make string to int respect behavior like PG
  3. refactor dummy column index

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 10, 2024
@sundy-li sundy-li marked this pull request as ready for review September 11, 2024 04:46
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 11, 2024
@sundy-li sundy-li requested review from b41sh, andylokandy and xudong963 and removed request for andylokandy September 11, 2024 04:46
@dosubot dosubot bot added A-planner Area: planner/optimizer pr-refactor this PR changes the code base without new features or bugfix labels Sep 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 11, 2024
@sundy-li sundy-li changed the title chore(query): reorder optimize rules chore(query): make string to int respect behavior like PG Sep 11, 2024
@sundy-li
Copy link
Member Author

Revert reorders, cause something wrong makes cluster ci hang

@sundy-li sundy-li marked this pull request as draft September 11, 2024 15:46
auto-merge was automatically disabled September 11, 2024 15:46

Pull request was converted to draft

@sundy-li sundy-li added the ci-benchmark Benchmark: run all test label Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-16428-34b10a9-1726107562

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@sundy-li sundy-li removed the ci-benchmark Benchmark: run all test label Sep 12, 2024
@sundy-li sundy-li marked this pull request as ready for review September 12, 2024 04:16
@sundy-li sundy-li added this pull request to the merge queue Sep 12, 2024
@dosubot dosubot bot added the A-query Area: databend query label Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@andylokandy andylokandy added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 12, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 12, 2024
@BohuTANG BohuTANG merged commit 2ca0036 into datafuselabs:main Sep 12, 2024
81 checks passed
@sundy-li sundy-li deleted the reorder-rules branch September 12, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

@xudong963 xudong963 xudong963 approved these changes

@b41sh b41sh Awaiting requested review from b41sh

Assignees
No one assigned
Labels
A-planner Area: planner/optimizer A-query Area: databend query lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. pr-refactor this PR changes the code base without new features or bugfix size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Databend Query Planner
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sundy-li @andylokandy @xudong963 @BohuTANG