Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][bigquery] --schema not working for underscore on bigquery #433

Closed
daja93 opened this issue Jan 22, 2024 · 0 comments · Fixed by #434
Closed

[BUG][bigquery] --schema not working for underscore on bigquery #433

daja93 opened this issue Jan 22, 2024 · 0 comments · Fixed by #434
Labels
bug Something isn't working invalid This doesn't seem right priority: high triaged: yes Has been approved for future implementation

Comments

@daja93
Copy link

daja93 commented Jan 22, 2024

Describe the bug
Selection of --schemas does not work for schemas with underscore. The link to get metadata about the schema from bigquery seems not understood by bigquery

To Reproduce
Steps to reproduce the behaviour:

  1. Run dbt-coves generate sources --schemas name_with_underscore

Expected behaviour
Generation of the selected schema

Console Log/Tracebacks
https://bigquery.googleapis.com/bigquery/v2/projects/my_project/datasets/%22name_with_underscore%22/tables?maxResults=100000&prettyPrint=false: Invalid dataset ID ""name_with_underscore"". Dataset IDs must be alphanumeric (plus underscores and dashes) and must be at most 1024 characters long.

Desktop (please complete the following information):

dbt-coves 1.6.26

python 3.11

@daja93 daja93 added the bug Something isn't working label Jan 22, 2024
@github-actions github-actions bot added invalid This doesn't seem right triaged: no Hasn't been approved for future implementation labels Jan 22, 2024
@BAntonellini BAntonellini added triaged: yes Has been approved for future implementation priority: high and removed triaged: no Hasn't been approved for future implementation labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right priority: high triaged: yes Has been approved for future implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants