-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix old SCTs that fail assertions #351
Labels
Comments
@hermansje Can you re-run the script Filip used to generate this list just so I can be sure it's up to date, if you have access to it? I did try re-running the script he linked to, but I don't have the required A lot of these courses have been very much updated since he filed this issue, and I don't want to duplicate work/accidentally break things further. Thanks! |
@klmedeiros It's down to 24:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since
pythonwhat v2.16.0
, different SCT functions do some assertions and verifications to figure out whether the function is appropriately used. You can see it in the CHANGELOG here.Some of these assertions are only done for courses whose course image contains the
PYTHONWHAT_V2_ONLY
env variable (more recent courses), because otherwise these changes would break 55 exercises that contain SCTs that violate these rules:This issue is a reminder that we have to rewrite the SCTs for these exercises because they are smelly. As soon as that is done, we can remove this
v2_only()
check and do the assertions for all SCTs, independent of thePYTHONWHAT_V2_ONLY
env variable.How I came up with this list
pythonwhat
that does not do theif v2_only()
checkdocker-python-shared
(usingpip install git+...
) and tag it (with a release candidate format, as it is never the intention to deploy)The text was updated successfully, but these errors were encountered: