[CDAP-15361] Fix set-type directive for decimal when scale is null #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in case it is null/not provided.
vanathi-g
reviewed
Oct 6, 2023
| @@ -317,7 +317,8 @@ public static Schema getSchemaForType(String type, Integer scale) throws Directi | |||
| type = type.toUpperCase(); | |||
| if (type.equals(ColumnTypeNames.DECIMAL)) { | |||
| // TODO make set-type support setting decimal precision | |||
| typeSchema = Schema.nullableOf(Schema.decimalOf(38, scale)); | |||
| scale = scale != null ? scale : 38; | |||
| typeSchema = Schema.nullableOf(Schema.decimalOf(76, scale)); | |||
There was a problem hiding this comment.
I think we can keep precision as 77 because according to the docs, a max precision of 76.76 is allowed. Besides, the other plugins (like Oracle) follow 38, 77 as default scale, precision.
vanathi-g
reviewed
Oct 9, 2023
saimukkamala
approved these changes
Oct 20, 2023
minurajeeve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix set-type directive for decimal by adding a default value for scale in case it is null/not provided.