-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CDAP-20948] BigQuery Delta Replication Plugin DataSet Project ID Fix #259
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -193,7 +193,7 @@ public void testGetMaximumExistingSequenceNumberForRetryableFailures() throws Ex | |
bqTarget.initialize(deltaTargetContext); | ||
} finally { | ||
//verify at least 1 retry happens | ||
PowerMockito.verifyStatic(BigQueryUtils.class, Mockito.atLeast(2)); | ||
PowerMockito.verifyStatic(BigQueryUtils.class, Mockito.atLeast(1)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why did this test change? It seems unrelated to your changes There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As per the new code changes, we do need to mock it twice, as it only requires 1 retry and if mocked twice. it break test in the second retry. |
||
BigQueryUtils.getMaximumExistingSequenceNumber(Mockito.anySet(), Mockito.anyString(), | ||
Mockito.nullable(String.class), Mockito.any(BigQuery.class), | ||
Mockito.nullable(EncryptionConfiguration.class), Mockito.anyInt()); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: revert ident change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project and conf.getDatasetproject() both are different project Id's.
Earlier it was pointing to project, now we are passing DatasetProjectId.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to say that we should revert the whitespace change (indent), not code change to point to the right project id