Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin-1730] Adding XLS UI elements for S3 source #200

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

psainics
Copy link
Contributor

Adding XLS UI elements for S3 source

Jira : Plugin-1730

Description

This PR adds UI element required for XLS Support in S3 Source.
Ref : XLS Support PR cdapio/hydrator-plugins#1835

Added Fields

  • Sample Size
  • Override
  • Terminate If Empty Row
  • Select Sheet Using
  • Sheet Value

A filter is used to show XLS specific values Terminate If Empty Row , Select Sheet Using, Sheet Value only when format XLS is selected.

Preview

image

Copy link

@DJSagarAhire DJSagarAhire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most comments from data-integrations/google-cloud#1368 are also applicable here. Looks good apart from those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants