Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): num of validators that didn't sign is always 0 #905

Open
wants to merge 2 commits into
base: v1.3-dev
Choose a base branch
from

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Sep 4, 2024

Issue being fixed or feature implemented

missing validators Prometheus metric is always 0

What was done?

Fix to correctly calculate missing validators.

How Has This Been Tested?

Started local devnet to monitor this parameter

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title fix(metrics): no of validators that didn't sign is always 0 fix(metrics): num of validators that didn't sign is always 0 Sep 4, 2024
@lklimek lklimek added this to the v1.3 milestone Sep 5, 2024
@lklimek lklimek self-assigned this Sep 5, 2024
@lklimek lklimek changed the base branch from master to v1.3-dev September 5, 2024 13:11
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 16, 2024
@lklimek lklimek marked this pull request as ready for review September 18, 2024 09:38
@lklimek lklimek removed the Stale label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review / testing
Development

Successfully merging this pull request may close these issues.

1 participant