Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(state): proposer selected twice when prev block round > 0 #904

Merged
merged 38 commits into from
Sep 19, 2024
Merged

fix(state): proposer selected twice when prev block round > 0 #904

merged 38 commits into from
Sep 19, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Sep 3, 2024 •
edited
Loading

Issue being fixed or feature implemented

What was done?

  • Added LastBlockRound to (internal) State data structure
  • Added consensus_version to ABCI consensus params (backwards-compatible ABCI protocol change)

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the base branch from v1.1-dev to v1.2-dev September 3, 2024 11:28
@lklimek lklimek changed the base branch from v1.2-dev to master September 3, 2024 11:28
@lklimek lklimek changed the title Fix/wrong proposer at round fix(state): proposer selected twice when prev block round > 0 Sep 3, 2024
@lklimek lklimek added this to the v1.3 milestone Sep 4, 2024
@lklimek lklimek self-assigned this Sep 5, 2024
@lklimek lklimek changed the base branch from master to v1.3-dev September 5, 2024 13:12
@lklimek lklimek marked this pull request as ready for review September 18, 2024 17:41
QuantumExplorer
QuantumExplorer requested changes Sep 19, 2024
View reviewed changes
docs/architecture/adr-d002-tenderdash-feature-versioning.md Outdated Show resolved Hide resolved
internal/consensus/state_proposaler.go Show resolved Hide resolved
internal/consensus/types/round_state.go Show resolved Hide resolved
light/provider/http/http.go Outdated Show resolved Hide resolved
@lklimek lklimek merged commit dce91b6 into v1.3-dev Sep 19, 2024
12 of 16 checks passed
@lklimek lklimek deleted the fix/wrong-proposer-at-round branch September 19, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@shumkov shumkov Awaiting requested review from shumkov shumkov is a code owner

Assignees

@lklimek lklimek

Labels
None yet
Projects
Platform team
Archived in project
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@lklimek @QuantumExplorer