Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump git-cliff to 2.4 and remove history before 1.0 #882

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Aug 15, 2024

Issue being fixed or feature implemented

  1. Changelog is very long, contains non-revelant information.
  2. Changelog is not generated correctly - some commits missing, due to bug in git-cliff that is already fixed

What was done?

  1. Updated git-cliff to 2.4
  2. Changed script to only include changes since 1.0.0
  3. Simplified git-cliff config
  4. Fixed issue with sha256sum file containing directory paths

How Has This Been Tested?

Run manually, will be tested during next release

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek added this to the v1.3 milestone Aug 15, 2024
@lklimek lklimek changed the title Build/cliff 2.4 build: bump git-cliff to 2.4 and remove history before 1.0 Aug 21, 2024
@lklimek lklimek modified the milestones: v1.3, v1.2 Aug 21, 2024
@lklimek lklimek marked this pull request as ready for review August 21, 2024 10:26
@lklimek lklimek changed the base branch from v1.2-dev to master August 29, 2024 09:36
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not affecting consenus so we can ship it with any version including 1.2.1

@lklimek lklimek merged commit 25e24d3 into master Aug 29, 2024
5 checks passed
@lklimek lklimek deleted the build/cliff-2.4 branch August 29, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants